Possible Bug in volumne_mesh_I.h

Submitted by mschramm on Mon, 07/26/2021 - 15:00

Hello,
I stumbled across the following just inside the function "calcVolPropertiesOfNewElement" (around line 120).
The function is setting 3d variables f0, f1, f2, and f3.
// assign nodes to faces
vectorConstruct3D(f0,0,1,2);
vectorConstruct3D(f1,0,3,1);
vectorConstruct3D(f2,0,2,3);
vectorConstruct3D(f1,1,3,2);
faceNodes_.set(n,0,f0);
faceNodes_.set(n,1,f1);
faceNodes_.set(n,2,f2);
faceNodes_.set(n,3,f3);

I believe this to be incorrect as f1 is used twice and f3 is only ever initialized. I believe the following should be used instead.
// assign nodes to faces
vectorConstruct3D(f0,0,1,2);
vectorConstruct3D(f1,0,3,1);
vectorConstruct3D(f2,0,2,3);
vectorConstruct3D(f3,1,3,2);
faceNodes_.set(n,0,f0);
faceNodes_.set(n,1,f1);
faceNodes_.set(n,2,f2);
faceNodes_.set(n,3,f3);

I have not had time to test if this is correct or not but wanted to get other's opinions/insights on this matter.

Thank you.