Fix breakparticle/force

Submitted by tkulju on Thu, 12/01/2011 - 09:39

Hi Christoph!
Thanks for the new release! I noticed something in fix breakparticle/force-code, which is buzzing me. In the fix_breakparticle_force.cpp:362 v_ins is defined, but it is never used (?). Instead v_insert is used in set_x_v_omega(...) (fix_breakparticle_force.cpp:371), which is (0,0,0), if it is not given in start-up script. Correct me if I'm wrong, but shouldn't the created particles have a momentum conserved velocity, instead of zero velocity what they now have?

Thanks,
Timo

ckloss's picture

ckloss | Sun, 12/04/2011 - 16:08

you're right, that's a typo :-) Should be

371: nins = pti->set_x_v_omega(pos_ins,v_ins,omega_ins,quat_insert);

Will correct that for the next release!

Thanks, Christoph

Silias | Tue, 01/31/2012 - 15:51

Hi,

will there be a doc to that fix and could you tell me the main features?

Thanks a lot,
kind regards,

Sebastian

ckloss's picture

ckloss | Tue, 01/31/2012 - 16:49

>>will there be a doc to that fix
at some point surely yes, but it's currently not very high up on the agenda. So currently you will have to dig through the code

Christoph