Bug report

Submitted by rqwang on Sun, 11/17/2013 - 19:11

Hi,

I might find a bug in cfdemSolverPiso.C and momCoupleModel/implicitCouple/implicitCouple.C

In cfdemSolverPiso.C
should Ksl.oldTime().internalField() = particleCloud.momCoupleM(0).impMomSource();
be Ksl.internalField() = particleCloud.momCoupleM(0).impMomSource(); ?

and in momCoupleModel/implicitCouple/implicitCouple.C line 164
tsource() = KslPrev_;
should be tsource() = KslNext_;?

Thanks.
rqwang

Forums:

rqwang | Thu, 11/21/2013 - 17:19

Any response?

cgoniva's picture

cgoniva | Fri, 11/22/2013 - 13:27

Hi rqwang,

Thx for having a close look at the code!

after the line:
Ksl.oldTime().internalField() = particleCloud.momCoupleM(0).impMomSource();
comes the line:
particleCloud.smoothingM().smoothen(Ksl);
which for no smoothing does:
field=field.oldTime();

so everything is fine here.

in momCoupleModel/implicitCouple/implicitCouple.C line 164
tsource() = KslPrev_;
this is correct, as just before that call the function:
resetMomSourceField()
is called, which does:
KslPrev_.internalField() = KslNext_.internalField();

so everything fine here as well.

Kind Regards,
Chris

rqwang | Fri, 11/22/2013 - 15:45

Hi Chris,

Thank you for the clarification. You are right, there is no bug. One more question:
in cfdemSolverPiso.C
- fvm::Sp(Ksl/rho,U) // the minus should be plus?
and
UEqn == - voidfraction*fvc::grad(p) + Ksl/rho*Us; //the plus should be minus here?

Thanks.
rq